search

LTTPP / Eemory

An Eclipse plug-in aimed at integrating Evernote within the Eclipse IDE
MIT License
7 stars 0 forks source link

Wrong behavior if choose "Not Now" when re-authenticate #76

Open HuilanZhang opened 9 years ago

HuilanZhang commented 9 years ago

Environment: Version: 1.1.0.201508030815 Java: 1.7.0_51 Windows 10 Eclipse Mars

Steps:

  1. Authenticate with 印象笔记.
  2. Configure clip configuration, check notebook, note, tag and comment, set existing notebook, leave the note field empty, set existing tag, add comment value.
  3. Go to 印象笔记， cancel the authentication.
  4. In Eclipse, do clip, an dialog window pops to ask to re-authentication.
  5. Click "not now".

Observed Behavior:

  1. After click "not now", then a Quick Organize windows pops with Note fields.
  2. Input a note name and click OK.
  3. Re-authentication window prompted again, click "Not Now", EDAMUserException throws: EDAMUserException(errorCode:AUTH_EXPIRED, parameter:authenticationToken) at com.evernote.edam.notestore.NoteStore$createNote_result.read(NoteStore.java:16793) at com.evernote.edam.notestore.NoteStore$Client.recv_createNote(NoteStore.java:1766) at com.evernote.edam.notestore.NoteStore$Client.createNote(NoteStore.java:1740) at com.evernote.clients.NoteStoreClient.createNote(NoteStoreClient.java:449) at com.prairie.eemory.client.impl.NoteOpsTextImpl.create(NoteOpsTextImpl.java:66) at com.prairie.eemory.client.impl.NoteOpsTextImpl.updateOrCreate(NoteOpsTextImpl.java:41) at com.prairie.eemory.client.impl.EeClipperImpl.clipSelection(EeClipperImpl.java:79) at com.prairie.eemory.handlers.EeHandler$3.run(EeHandler.java:226) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

Expected Results:

  1. No need to check the clip configuration if re-authentication is cancelled.
  2. Should tell user that the exact error message instead of throwing an exception.