LUCIT-Systems-and-Development / unicorn-binance-rest-api

A Python SDK by LUCIT to use the Binance REST API`s (com+testnet, com-margin+testnet, com-isolated_margin+testnet, com-futures+testnet, us, tr) in a simple, fast, flexible, robust and fully-featured way.
https://unicorn-binance-rest-api.docs.lucit.tech
Other
61 stars 17 forks source link

Async support? #15

Open lixiao-ibd opened 2 years ago

lixiao-ibd commented 2 years ago

First of all, thank you for the great work!

Is your feature request related to a problem? Please describe. I need to run some tasks in parallel, the repo sammchardy/python-binance supports this and it works well. I am considering to switch to this repo(unicorn-binance-rest-api) because I am impressed by the unicorn-binance-websocket-api repo, and I see this repo is more active than sammchardy/python-binance.

Describe the solution you'd like Anything similar to what sammchardy/python-binance does, it is well documented: https://sammchardy.github.io/async-binance-basics/

Describe alternatives you've considered Well, continue to use sammchardy/python-binance for the async rest api and use this repo for the stream api

Additional context None

oliver-zehentleitner commented 2 years ago

Hello!

Thanks for your interesst in this lib!

Its on the roadmap but will need a while!

You can mix with python binance, but we are not allways on the same versions of websockets, so sometimes its not easy to install both paralell, thats why i forked the rest api.

oliver-zehentleitner commented 2 years ago

I think about how to implement asyncio support... a possible way is https://pypi.org/project/grequests/

https://code.luasoftware.com/tutorials/algo-trading/python-binance-asyncio-client/

yarimiz commented 1 year ago

Hey @oliver-zehentleitner , any news regarding the async support for REST requests?

oliver-zehentleitner commented 1 year ago

I will pick this up soon, need this then: https://smarie.github.io/python-decopatch/

daviduhm commented 1 year ago

Can't wait for it! Thank you @oliver-zehentleitner