gronastech commented 3 years ago

PR Details

Description

Bug fix for:

unicorn_binance_websocket_api/unicorn_binance_websocket_api_manager.py", line 1300, in create_websocket_uri elif "!" in market: UnboundLocalError: local variable 'market' referenced before assignment

added default empty values for market & channel

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

oliver-zehentleitner commented 3 years ago

Any news?

oliver-zehentleitner commented 3 years ago

Please do some conversation with me! I dont want to merge a PR if I have to fix something afterwards. So please remove the changes in unicorn_binance_websocket_api/unicorn_binance_websocket_api_manager.py or I will close this.

Thanks and best regards, Oliver

LUCIT-Systems-and-Development / unicorn-binance-websocket-api

Bug fix #142