search

LUCIT-Systems-and-Development / unicorn-binance-websocket-api

A Python SDK by LUCIT to use the Binance Websocket API`s (com+testnet, com-margin+testnet, com-isolated_margin+testnet, com-futures+testnet, com-coin_futures, us, tr, dex/chain+testnet) in a simple, fast, flexible, robust and fully-featured way.
https://unicorn-binance-websocket-api.docs.lucit.tech/
Other
677 stars 166 forks source link

add the option to daemonize threads #264

Closed MoeQatoum closed 2 years ago

MoeQatoum commented 2 years ago

Is your feature request related to a problem? Please describe.

why not add the option to daemonize threads , so they would be killed if main thread is closed. in my case if I close the main window of my app , the process is still alive due this issue , I think it would be easier and more convenient to just daemonize threads rather than closing them manually.

I looked in to the code it's a couple of lines modification.

thanks for your great work !

Describe the solution you'd like.

No response

Describe alternatives you've considered

No response

Additional context

No response

oliver-zehentleitner commented 2 years ago

hi! thanks for the suggestion.

I tried to fix some other issues, but fixing them caused this new behavior. threads and loops must be stopped clearly during runtime, not only when closing the application.

In a few weeks this will be fixed with a clean solution.