MARKET orders should not set params "price" and "timeInForce"

LUCIT-Systems-and-Development / unicorn-binance-websocket-api

A Python SDK by LUCIT to use the Binance Websocket API`s (com+testnet, com-margin+testnet, com-isolated_margin+testnet, com-futures+testnet, com-coin_futures, us, tr, dex/chain+testnet) in a simple, fast, flexible, robust and fully-featured way.

Other

677 stars 166 forks source link

Version of this library.

1.46.1

Solution to Issue cannot be found in the documentation or other Issues and also occurs in the latest version of this library.

[X] I checked the documentation and other Issues. I am using the latest version of this library.

Hardware?

Local server/workstation

Operating System?

Windows

Python version?

Python3.10

Installed packages

No response

Logging output

No response

Processing method?

stream_buffer

Used endpoint?

concerns all

Issue

The create_order method always sets params "price" and "timeInForce" but that triggers an error from Binance for MARKET orders since those two params do not make sense for them.

The code should only set those params if the order_type is != "MARKET".

Thanks!

I have updated the create_order() and create_test_order() functions according to these instructions.

Order `type`	Mandatory parameters
`LIMIT`	`timeInForce` `price` `quantity`
`LIMIT_MAKER`	`price` `quantity`
`MARKET`	`quantity` or `quoteOrderQty`
`STOP_LOSS`	`quantity` `stopPrice` or `trailingDelta`
`STOP_LOSS_LIMIT`	`timeInForce` `price` `quantity` `stopPrice` or `trailingDelta`
`TAKE_PROFIT`	`quantity` `stopPrice` or `trailingDelta`
`TAKE_PROFIT_LIMIT`	`timeInForce` `price` `quantity` `stopPrice` or `trailingDelta`

After extensive testing, I will create new packages for the installation. I will let you know here as soon as they are available.

LUCIT-Systems-and-Development / unicorn-binance-websocket-api