search

LUCIT-Systems-and-Development / unicorn-binance-websocket-api

A Python SDK by LUCIT to use the Binance Websocket API`s (com+testnet, com-margin+testnet, com-isolated_margin+testnet, com-futures+testnet, com-coin_futures, us, tr, dex/chain+testnet) in a simple, fast, flexible, robust and fully-featured way.
https://unicorn-binance-websocket-api.docs.lucit.tech/
Other
683 stars 164 forks source link

Raise `StreamRecoveryError` instead of `ValueError` #67

Closed oliver-zehentleitner closed 4 years ago

oliver-zehentleitner commented 4 years ago

Is your feature request related to a problem? Please describe.

Describe the solution you'd like It makes sense to create a specific error msg for non recoverable streams. https://github.com/oliver-zehentleitner/unicorn-binance-websocket-api/blob/e68d8945ad4c6abd9aecfc47658d8df632af8b3c/unicorn_binance_websocket_api/unicorn_binance_websocket_api_manager.py#L162 https://github.com/oliver-zehentleitner/unicorn-binance-websocket-api/blob/32dc5406bb2c3f835a291bcf431461e5c4fe19a6/unicorn_binance_websocket_api/unicorn_binance_websocket_api_connection.py#L83

Describe alternatives you've considered

Additional context