search

LUCIT-Systems-and-Development / unicorn-binance-websocket-api

A Python SDK by LUCIT to use the Binance Websocket API`s (com+testnet, com-margin+testnet, com-isolated_margin+testnet, com-futures+testnet, com-coin_futures, us, tr, dex/chain+testnet) in a simple, fast, flexible, robust and fully-featured way.
https://unicorn-binance-websocket-api.docs.lucit.tech/
Other
683 stars 164 forks source link

dependencies #71

Closed benzkji closed 4 years ago

benzkji commented 4 years ago

I dont get why it needs flask and other strange packages (itsdangerous...?)...maybe it would help to

  1. clearly specify dependencies in the readme
  2. put monitoring and other "gadgets" into contrib or other packages, so the main thing needs only the bare minimum of dependencies

what do you think?

oliver-zehentleitner commented 4 years ago

Hi benzkji!

flask for example gets installed on the system with the installation (user friendly) and gets only loaded/imported if you start the server: https://github.com/oliver-zehentleitner/unicorn-binance-websocket-api/blob/master/unicorn_binance_websocket_api/unicorn_binance_websocket_api_restserver.py

So I guess its not insecure if you dont start the lib on your own and its the most uncomplicated way to ship all at once.

The list to the dependencies is linked here: https://github.com/oliver-zehentleitner/unicorn-binance-websocket-api#description

Best regards, Oliver

edit: I get the point, I understand why its good to avoid every unused code on a system.

I think the current approach is the comfortable way. Switching the structure now would be a lot of work and it breaks the behaviour of the current code base. If someone wants to do that work and its working fine, i would merge it. I have my focus on stability and performance and i add some code thats helping me with that.

But it could also be good for you to uninstall unused packages afterwards or you fork the repository, modify setup.py and requirements.txt to fit to your needs and install like pip install https://github.com/oliver-zehentleitner/unicorn-binance-websocket-api/tarball/master --upgrade but fitting to your fork. Then you get within a few minutes the same result.

benzkji commented 4 years ago

yes, it's about maintenance, etc. the less the better ;-)