LUCIT-Systems-and-Development / unicorn-binance-websocket-api

A Python SDK by LUCIT to use the Binance Websocket API`s (com+testnet, com-margin+testnet, com-isolated_margin+testnet, com-futures+testnet, com-coin_futures, us, tr, dex/chain+testnet) in a simple, fast, flexible, robust and fully-featured way.
https://unicorn-binance-websocket-api.docs.lucit.tech/
Other
683 stars 164 forks source link

Issue #79 and #85 #97

Closed uggel closed 4 years ago

uggel commented 4 years ago

Package configuration fixed

PR Details

Description

Package configuration is wrong. Currently one needs to have the bin-folder of the venv in the PATH. That is not feasible since you often have one venv per project.

Related Issue

Issue #79 and #85

Motivation and Context

How Has This Been Tested

Types of changes

Checklist

oliver-zehentleitner commented 4 years ago

Hi uggel!

Thank you for fixing this issue!

Does the init file only works without the shebang and the other comments from https://github.com/oliver-zehentleitner/unicorn-binance-websocket-api/blob/master/unicorn_binance_websocket_api.py ?

best regards, Oliver

uggel commented 4 years ago

Hi Oliver! Yes that is correct. Initially init.py isempty to tell the environment that this is a module. The shebang-stuff is present in the py-files in the bin-folder because they are python scripts that are supposed to be run from cli.