LUCIT-Systems-and-Development / unicorn-fy

A Python SDK by LUCIT to convert received raw data from crypto exchange API endpoints into well-formed python dictionaries.
https://unicorn-fy.docs.lucit.tech
MIT License
54 stars 20 forks source link

add userdata order_trade_update #23

Closed StarBalll closed 3 years ago

StarBalll commented 3 years ago

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

Checklist

oliver-zehentleitner commented 3 years ago

Hello @StarBalll

Thank you very much for you contribution!

I have to points to discuss:

  1. can you please provide English comments instead of Chinese?
  2. ACCOUNT_UPDATE is in "pass" mode :) that way i can release that ...
  3. we have to add test units, i could do that, but would you be able to provide me the raw data of the new added events?

Best regards, Oliver

StarBalll commented 3 years ago

ex.txt

oliver-zehentleitner commented 3 years ago

Thanks a lot! :+1: