Closed Tidone closed 10 months ago
Plese wait a bit before you merge this.
I forgot to check & update some of the more obscure streams. I will do that in the next few days.
thanks for the updates, sure i wait :)
This PR is now ready.
I checked & updated all futures streams. I also properly implemented all coin-futures streams.
The explicit call to .keys() is not only not necessary but will also be much slower because a new list of all keys is generated and searched linearly, instead of using the dictionary's hashing algorithm.
in
checks if a key is in a dictionary:
if 'key' in dict:
If you want to check the values too you have to explicitly call .values():
if 'value' in dict.values():
Also see these SO answers.
Cool, I did not expect this:
d = {'a': 1, 'b': 2}
if 'a' in d:
print(f"Key found!")
if '2' in d:
print(f"Value found!")
Thank you!
Btw, both PRs are ready to be merged.
Thanks again and sorry it took so long, but the UNICORN Binance Suite has become a full-time job and I only now have the resources for further development.
PR Details
Description
Updated all futures market streams:
24hrMiniTicker
,24hrTicker
,depth
,ORDER_TRADE_UPDATE
&MARGIN_CALL
markPrice
,continuous_kline
,bookTicker
,forceOrder
&compositeIndex
,Related Issue
26
Motivation and Context
How Has This Been Tested
Types of changes
Checklist