Columns that are missing in old clients

[Xiphoseer]

We use paradox-typed-db based on 1.10.64, but we want ParadoxServer to work with old clients ideally. This issue is to track columns that were added recently that we should ignore completely if missing:

• [x] Activities:gate_version
• [x] DeletionRestrictions:gate_version
• [x] DestructibleComponent:factionList
• [x] ItemComponent:commendationLOT
• [x] MissionTasks:gate_version
• [x] Objects:_internalNotes
• [x] Objects:gate_version

[aronwk-aaron]

• [x] Missions:isRandom

  INFO  paradox_server::api                > API Route: Rev(MissionTypeBySubTy(PercentDecoded("Battle"), PercentDecoded("General")))
  The application panicked (crashed).
  Message:  Missing column isRandom in Missions
  Location: /tmp/cargo-installSeyNb9/release/build/paradox-typed-db-b8bb06966298c829/out/rows.rs:1

[Xiphoseer]

Missions:isRandom

Turns out this wasn't the same sort of bug, but an entirely different class that should be fixed now

[aronwk-aaron]

I think this issue can be closed as we now have the oldest client in our possession up and running with lu-explorer

[Xiphoseer]

Are there still warnings in the logs? The current code just doesn't crash under any circumstances, but that doesn't mean it doesn't try to read those columns anymore.

(ie paradox-typed-db is more forgiving now, but will still complain the server is calling it wrong)

[aronwk-aaron]

oh right! I'll grab those logs and document what it is complaining about

[aronwk-aaron]

These are the ones I see in logs

 WARN  paradox_typed_db::rows         > Missing column gate_version in ZoneTable
 WARN  paradox_typed_db::rows         > Missing column gate_version in SpeedchatMenu
 WARN  paradox_typed_db::rows         > Missing column gate_version in UgBehaviorSounds
 WARN  paradox_typed_db::rows         > Missing column gate_version in SkillBehavior