search

LUH-DBS / Matelda

Apache License 2.0
0 stars 0 forks source link

Handles files like folders #2

Closed MarcSpeckmann closed 6 months ago

MarcSpeckmann commented 1 year ago

When the operating system creates files like .DS_Store, the programme uses .DS_Store like a folder and crashes.

https://github.com/LUH-DBS/ED-Scale/blob/9e21c42ea70aeae20a8200f1aad2db74d5b2b5a3/dataset_clustering.py#L60-L70

FatemehAhmadi94 commented 1 year ago

@XxHalbfettxX Fixed?

MarcSpeckmann commented 1 year ago

The fix works, for the .DS_Store and similar files. An advanced solution can be that we also check with os.path.isdir. Additionally, you could write a module/class that is only responsible for loading the data, so there is less duplicate code and maintenance is easier.

I didn't create a pull request for this because I'm not sure how important something like this is to you in this project.