search

LUMC-BioSemantics / ERN-common-data-elements

Creative Commons Zero v1.0 Universal
2 stars 13 forks source link

Dubious about representation of gender #2

Open markwilkinson opened 5 years ago

markwilkinson commented 5 years ago

In the "Personal Information" model, you have made a Snomed URI the value of the sio "has value" predicate. This is... likely not a great way to do it.

The measurement-value node could be rdf:type snomedct:feminine_gender, and the "has value" be "Female" or something like that... but it's likely not a good idea to use a Class URI as the value of a has-value predicate (which is intended to be some kind of literal)

rajaram5 commented 5 years ago

Hi Mark,

If I understood your comments correctly, then the model should look something like this right?

P a ncbi:homo_sapiens P sio:has-attribute A

A sio:has-measurement-value MV

MV a snomedct:feminine_gender MV sio:has-value "Female"

markwilkinson commented 5 years ago

I think that's what I suggested...

M

On 6/13/19 12:18 PM, Rajaram wrote:

Hi Mark,

If I understood your comments correctly, then the model should look something like this right?

P a ncbi:homo_sapiens P sio:has-attribute A

A sio:has-measurement-value MV

MV a snomedct:feminine_gender MV sio:has-value "Female"

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LUMC-BioSemantics/ERN-common-data-elements/issues/2?email_source=notifications&email_token=AAHQ2LU2N5JE4WBJGN3LDRDP2INGJA5CNFSM4HXWT3FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXTHLDY#issuecomment-501642639, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHQ2LTBU4TLQHP4JXE2LLLP2INGJANCNFSM4HXWT3FA.

--

Mark Wilkinson Madrid, Spain

rajaram5 commented 5 years ago

Hi Mark, I don't think measurement value node will work here. According to sio class definition measurement value is subtype of number. Looks like we can't use it to represent string.

www ebi ac uk_ols_ontologies_sio_terms_iri=http%3A%2F%2Fsemanticscience org%2Fresource%2FSIO_000070

rajaram5 commented 5 years ago

What about these two options?

Option 1

P a ncbi:homo_sapiens P sio:has-attribute A

A a ncit:Sex A rdf:value SV

SV a snomedct:feminine_gender

In option 1 we may have to map parent class of ncit:Sex as an equivalentClass to sio:Attribute

Option 2

P a ncbi:homo_sapiens P sio:has-attribute A

A a sio:Attribute A sio:isAbout ncit:Sex A rdf:value SV

SV a snomedct:feminine_gender