LVPlayground / playground

The Las Venturas Playground gamemode
Other
33 stars 23 forks source link

Quick Feedback - Gang System #149

Closed ghost closed 8 years ago

ghost commented 8 years ago

untitled

untitled

Other than that, I see no issues. Tested all the available commands and they seem to work fine (other than changing values via /gang settings, which Russell mentioned is incomplete)

RussellLVP commented 8 years ago

It's possible to invite yourself to the gang.

https://github.com/LVPlayground/playground/commit/dfb4e11a28cf431d3dd0d4bda7badfe94511ba97

... the output was the same as in the screenshot above ...

https://github.com/LVPlayground/playground/commit/8df8771869f2478ffa7fbd477c2e0fd32b172bfb

... but it also shows "Type '/gangs top' to list...blah" underneath.

https://github.com/LVPlayground/playground/commit/56bc68959f2c894d061f1925472ad91b46d5b019

There is no flood limit, it's possible to /gang invite [id] as much as you wish

https://github.com/LVPlayground/playground/commit/29b1957f46c42d712df8af2d5b7421ac0885a47e

I created a gang (as the only member) and then left it (/gang leave). What happens then?

Right now the gangs table does not have to be modified, existence of a gang is judged by having members in it. In the long term we may want to modify this for performance reasons on the website, but this is not necessary now.

I created a gang, left the server, rejoined (and logged in) and I wasn't a member of any gangs.

The database tells me that you're in two gangs at once, well done :). Any idea how your account may have ended up this way? Did you re-join a gang after reconnecting?

ghost commented 8 years ago

The database tells me that you're in two gangs at once, well done :). Any idea how your account may have ended up this way? Did you re-join a gang after reconnecting?

Not too sure how this happened. I just created a fresh account (nickname: Granny2), joined the server, used /gang create, got confirmation that it was created, left the server, rejoined and same result - I'm not in a gang.

RussellLVP commented 8 years ago

I have fixed that problem as well, which was because your data could not be loaded due to a bug. Let's close this— please create many more awesome bugs for any issues you find :D