search

LVPlayground / playground

The Las Venturas Playground gamemode
Other
33 stars 23 forks source link

Update rules.json #789

Closed FreakinsPL closed 4 years ago

FreakinsPL commented 4 years ago

Thank you for making a contribution to Las Venturas Playground!

Please take a moment to fill in the questions in this template, to make it easier for our developers to understand what you're doing.

What is being changed?

Updating /rules; adding a line "Advertising is NOT ALLOWED"

Why is this being changed?

Necessary

How are you making the change?

I have tested this change myself on my local server.

FreakinsPL commented 4 years ago

Shall we remove "DO NOT avoid death by means of quitting" line from /rules ?? @Russell

XilentLVP commented 4 years ago

I suggest keeping the same message - 'DO NOT' @FreakinsPL What about a little change in 'DO NOT advertise'?

FreakinsPL commented 4 years ago

I will update it soon From "Advertising NOT ALLOWED" to "DO NOT Advertise 😄

Btw I am confused in that "quit to avoid death" rule coz it will now grants kill to the player according to LVP 50 update 😓

@XilentLVP @Specifer

Specifer commented 4 years ago

I'm afraid it's for the managers to exactly determine this rules.json. A minor mistake in this could have players mentioning as there is no rule about what they did.

RussellLVP commented 4 years ago

Could you have a look at the changed files please? Only a teeny tiny subset is relevant to this PR, you might have to rebase and update.

https://github.com/LVPlayground/playground/pull/789/files

FreakinsPL commented 4 years ago

Sorry for this mess I will update it soon..

Specifer commented 4 years ago

@FreakinsPL , I see you have deleted you're repo to refork. So now onwards for every PR you make. you should create a new branch. and I learned this by closing so many PR's again and again.

Specifer commented 4 years ago

Closed by request of @FreakinsPL .