Prevent players from sending money to NPC or himself - Githubissues

LVPlayground / playground

The Las Venturas Playground gamemode

Other

32 stars 23 forks source link

Prevent players from sending money to NPC or himself #819

Closed FreakinsPL closed 4 years ago

FreakinsPL commented 4 years ago

Thank you for making a contribution to Las Venturas Playground!

Please take a moment to fill in the questions in this template, to make it easier for our developers to understand what you're doing.

What is being changed?

OnPlayerCommandText.pwn

Why is this being changed?

Update

How are you making the change?

I have a working check-out of Las Venturas Playground.
I have included tests for any changed JavaScript code.
I have tested this change myself on my local server.

OttoRocket-LVP commented 4 years ago

Hello Freakins,

Thank you for your contribution!

However the givecash command is now handled in JavaScript here: https://github.com/LVPlayground/playground/blob/512a67d67a03b9074883cf2ec8ee4a33fa55adfb/javascript/features/finance/financial_commands.js#L36

This already includes the following cases:

You can't send money to yourself.
When wending money to NPCs it'll instead be donated to a chairty.

After giving it a double check the givecash has already been removed from the pawn implementaiton. Russell might've just beaten you to the fix. :-)