search

LVPlayground / playground

The Las Venturas Playground gamemode
Other
32 stars 23 forks source link

Update limits in death_match_manager #836

Closed Specifer closed 2 years ago

Specifer commented 3 years ago

Does this solve issue #771?

OttoRocket-LVP commented 3 years ago

Hello Specifer,

Thank you for your contribution!

This might indeed be what will solve the linked issue. Can you please test it on your local server?

I believe you'll also want to add a wait(0).then(() => player.updateStreamer...) to avoid the reentrancy warnings.

Specifer commented 3 years ago

Holsje?

OttoRocket-LVP commented 3 years ago

Heya, thank you for the modifications! :) Did you test it on your local server?

Would also be nice if you'd add a tab at line 219

Specifer commented 3 years ago

It's not working :(

Callback (98) ignored because a ScopedIgnore is in place. [23:10:38] [WARNING][callback_hook.cc:80] Callback (OnPlayerActivityChange) ignored << because a ScopedIgnore is in place. [23:10:38] [WARNING][callback_hook.cc:80] Callback (OnPlayerActivityChange) ignored << because a ScopedIgnore is in place.

Specifer commented 3 years ago

@OttoRocket-LVP. Done! and tested.

OttoRocket-LVP commented 3 years ago

Thanks for the update!

There's a limits class you should use for this instead.

Also there's limit checks at enterDeathMatchZone I believe it would fit there better.

Specifer commented 3 years ago

There are some test errors since I didn't modify the test, which I will apart from that any probs?

OttoRocket-LVP commented 3 years ago

Try running the tests again. I believe some gang related are somewhat involved with a random and thus not consistent. Something we should look into.