search

LVPlayground / playground

The Las Venturas Playground gamemode
Other
32 stars 23 forks source link

Making some cmds more sensible #840

Closed FreakinsPL closed 3 years ago

FreakinsPL commented 3 years ago

Changes:- You can't call, mute, report NPCs anymore. Changes:- You can't ignore yourself anymore.

edit:- Just found out NPCs are considered unregistered so we can't add them friends either [Removing my condition for NPCs :( ]

Thank you for making a contribution to Las Venturas Playground!

Please take a moment to fill in the questions in this template, to make it easier for our developers to understand what you're doing.

What is being changed?

messages.json call_commands.js ignore_commands.js mute_commands.js report_commands.js

Why is this being changed?

To make it more sensible

How are you making the change?

[ ] I have a working check-out of Las Venturas Playground. [ ] I have included tests for any changed JavaScript code. [ DONE ] I have tested this change myself on my local server.

OttoRocket-LVP commented 3 years ago

Heya,

Thank you for your commit once again!

I think you should be able to ignore bots if you wish to. If people don't want to see Gunther's talk they should be able to.

On a note, players would be able to avoid the ignore of others by using Gunther's translate option to still talk to them.

OttoRocket-LVP commented 3 years ago

Heya Freakin, sorry one nitty picky detail. The names in data/messages.json are supposed to be ordered alphabetically. Could you please update this?

Also please don't forget to undo changes in javascript/features/friends/friends_commands.js

FreakinsPL commented 3 years ago

Making a new PR coz this one looking kinda messy.