LWJGL / lwjgl3-osgi

OSGi support for LWJGL 3
BSD 3-Clause "New" or "Revised" License
4 stars 5 forks source link

Test Windows #3

Closed io7m closed 7 years ago

io7m commented 7 years ago

Verify that the bundles resolve and run on Windows x86/x86_64.

Martin-Idel commented 7 years ago

Evaluation: The MANIFEST.MF contains "osname=Windows". According to the OSGI specification (core specification 6.0.0, pg 100-101) from osgi.org, the correct name would be "Windows 10" (similarly for other Windows). There is no alias "Windows". In order to target most Windows versions, the alias "Win32" can be used (excluding Windows Server 2008 and WindowsCE).

However, I could not verify that the name in the MANIFEST.MF must be the complete OS name and cannot be a partial name. If this was the case, the error would be on the side of equinox of course.


Proposed Fix: I rewrote the MANIFEST.MF in the above packages replacing "Windows" by "Win32" and everything worked fine. If you agree that this should be fixed, I can offer to make the change in all packages and propose a Pull Request if it helps.

io7m commented 7 years ago

Proposed Fix: I rewrote the MANIFEST.MF in the above packages replacing "Windows" by "Win32" and everything worked fine. If you agree that this should be fixed, I can offer to make the change in all packages and propose a Pull Request if it helps.

I agree. I'd certainly appreciate a PR!

Thanks again for testing these. I don't have access to a usable Windows or OS X environment right now, so it's always good to get reports from those that do.

io7m commented 7 years ago

I think we can assume that this is sufficiently tested now. We'll add new problems in new tickets.

Martin-Idel commented 7 years ago

One last question for planning purposes: Do you know when the new version with the fix will be released on Maven Central?

io7m commented 7 years ago

I was thinking about this yesterday... For reasons of sanity, I'd like to keep the bundles' version numbers in lock step with the LWJGL libraries. This probably means that the fix will go out with the next LWJGL release.

@Spasi Any thoughts?

Spasi commented 7 years ago

Not sure if there's a decent alternative to waiting for 3.1.3.

io7m commented 7 years ago

I'm not aware of one.

Martin-Idel commented 7 years ago

That's what I thought and I agree that this is probably the only decent way. Thanks for the quick response!