Change osname of Windows systems to comply with OSGI spec

LWJGL / lwjgl3-osgi

OSGi support for LWJGL 3

BSD 3-Clause "New" or "Revised" License

4 stars 5 forks source link

Change osname of Windows systems to comply with OSGI spec #7

Closed Martin-Idel closed 7 years ago

Martin-Idel commented 7 years ago

This fixes the issues on Windows described in https://github.com/LWJGL/lwjgl3-osgi/issues/3

I tested it in the following way:

compiled the plugin with "mvn clean verify" and used in my Eclipse plugin.
System: Windows 10 (two systems, one usual Windows host and a Windows guest in a vbox on Ubuntu), x_86
OSGI-Implementation: Equinox of Mars Eclipse IDE
Archives: org.lwjgl.lwjgl and org.lwjgl.opengl

Result: There seem to be no issues now.

io7m commented 7 years ago

Excellent. Thanks again!

darxriggs commented 7 years ago

LWJGL 3.1.3 was released. Is there a chance that this change is released as 3.1.3 in this artifact too?

io7m commented 7 years ago

@darxriggs I'll try to get a release of these bundles out within the next couple of days. They'll definitely contain the above fix.

io7m commented 7 years ago

3.1.3 was just deployed to Central. The artifacts should be resolvable right now, but as per usual, it'll take at least an hour before they appear in search results.

Apologies for the delay; I actually managed to completely miss the 3.1.3 announcement and thought that it was the previous release.

darxriggs commented 7 years ago

Works like a charm. Thanks.