Vulkan: Many `VkPresentInfoKHR` Buffer Setters Don't Update Size Fields

LWJGL / lwjgl3

LWJGL is a Java library that enables cross-platform access to popular native APIs useful in the development of graphics (OpenGL, Vulkan, bgfx), audio (OpenAL, Opus), parallel computing (OpenCL, CUDA) and XR (OpenVR, LibOVR, OpenXR) applications.

https://www.lwjgl.org

BSD 3-Clause "New" or "Revised" License

4.67k stars 631 forks source link

Vulkan: Many `VkPresentInfoKHR` Buffer Setters Don't Update Size Fields #796

Closed gudenau closed 1 year ago

gudenau commented 1 year ago

Version

3.3.1

Platform

Linux x64

JDK

openjdk 19-ea 2022-09-20

Module

Vulkan

Bug description

Many setters in o.l.v.VkPresentInfoKHR do not update the related size fields in the structure when invoked, most other setters that take a buffer handle this automatically. There is an example of this in the same class for the field pWaitSemaphores

The affected setters are

pSwapchains/npSwapchains
pImageIndices/npImageIndices
pResults/npResults

Stacktrace or crash log output

No response

gudenau commented 1 year ago

I just found that o.l.v.VkSubpassDescription has similar issues with the following setters:

pColorAttachments/npColorAttachments
pResolveAttachments/npResolveAttachments

octylFractal commented 1 year ago

Those specifically are currently on purpose, see #539. I suspect the main ones in your issue are as well.

gudenau commented 1 year ago

Ah, probably the same thing then.