search

LWJGL / lwjgl3

LWJGL is a Java library that enables cross-platform access to popular native APIs useful in the development of graphics (OpenGL, Vulkan, bgfx), audio (OpenAL, Opus), parallel computing (OpenCL, CUDA) and XR (OpenVR, LibOVR, OpenXR) applications.
https://www.lwjgl.org
BSD 3-Clause "New" or "Revised" License
4.67k stars 628 forks source link

Crypt32 bindings #851

Closed TheMrMilchmann closed 1 year ago

TheMrMilchmann commented 1 year ago

Bindings for dpapi.h and crypt32.dll providing support for:

This is not fully finished yet and I'll add some questions inline.

TheMrMilchmann commented 1 year ago

(Pinging @Spasi to have a look at this because I'm not sure if GitHub notifies people about draft PRs. No hurry though. 😅)

Spasi commented 1 year ago

Hey @TheMrMilchmann,

I've added a commit that addresses the above questions. Will split/squash/cleanup the commits as necessary when it's time to merge this.

TheMrMilchmann commented 1 year ago

Thanks, I just looked at your changes and I believe you have already taken care of all remaining issues. In my opinion, this is good to go. However, I'm not sure where to mention this in the changelog. Could you also take care of this? Otherwise, let me know if anything else is missing.

Spasi commented 1 year ago

Thanks @TheMrMilchmann!

Did one more change before the merge, added IgnoreMissing.. to CryptProtectMemory and CryptUnprotectMemory because technically we support Windows XP and these two are available on Vista+.