LWSS / Fuzion

Fuzion is a free-as-in-freedom CSGO cheat for linux
GNU General Public License v3.0
337 stars 149 forks source link

CTD on Config load. #367

Closed xdovahkinx closed 5 years ago

xdovahkinx commented 5 years ago

I posted a comment #309 for this, but idk; might be a different cause or somethin.

So summary, I ./update'ed today, so I should be on the latest stable build as of 6/1/19. When I loaded my existing config, it resulted in a CTD. I did it again to verify it was infact the config load that did it.

I deleted my configs, thinking there was probably an issue with them or something, and I'd just remake them.

After spending about 30 mins or so making my default config, I saved and restarted. I loaded the config, and it CTD'd again. I also did it again to verify.

Is this related to the previous issue before? Should I just ./update again and try under a different library name.

xdovahkinx commented 5 years ago

Small update, I have ran ./update several times. Decided to rebuild the cheat entirely so I wiped the directory and re-cloned. Upon build it threw errors because ImGUI was missing, so I restored those files and it built successfully.

I ran a quick ./update to ensure fresh build.

Still get CTD on config load. I also saw in glitter some rumors of the filename causing bugs based on capitol letters. I renamed my config and still received no luck.

ZepniroX commented 5 years ago

https://github.com/LWSS/Fuzion/pull/321

xdovahkinx commented 5 years ago

Forgive me, but I am a little hazy; what classes as "Cosmetic". Are we talking things like UI coloring/etc, or things like the skin changer? (Edit, I looked at the actual file changes (I am not well-versed in C++, so I don't usually go poking in something I am over my head in.), and see that we are talking specifically with the skin changer. I don't have it enabled, but I assume that it doesn't have to be for the crash to occur. I am going to go through the process of omitting those settings in attempt to make the config work (I know JSON can be touchy some times though))

I will pastebin my CFG, if you would be so kind, tell me what parts you think are actually relevant to that PR. Also, has this been merged yet or no? If not, what else can be done to contribute to it?

My CFG(s): https://pastebin.com/TUrnah1D << Postupdate https://pastebin.com/UcPjQYyE << Preupdate Default https://pastebin.com/uKmEtTvU << Preupdate w/ Aim.

I'd also like to note that there have been quite a few different references to CTDs on config loads, and not all of them have been believed to be part of the reasons described in that PR; Some were suggesting bugs with HvH/Anti-Aim stuff, whereas this PR seems to be about the way JSON is doing it's thing. I didn't dive too deeply to be fair, and I might be oversimplifying, and it is entirely possible that this is entirely the same issue as #309

I can't exactly build reproducible steps as these seem to be to random, if not client-errored. I have seen some stuff in glitter about it, but nobody else has posted as part of this issue.

xdovahkinx commented 5 years ago

Alright, I can confirm that the problem was that suggested by @ZepniroX (thank you), specifically the problem described in #321.

After a little digging (arguably something I should've done to begin with anyways), I removed lines 890-1286, the lines that pertain to the skin-changer in the case of my CFG. Doing so allowed the config to load.

I'm gonna go ahead and close out the issue. Thanks.