search

LWollatz / LungJ

providing a Plug-In for Fiji / ImageJ for segmenting images, too large to process in RAM at once as well as several other tools for image segmentation & processing.
http://imagej.net/LungJ
1 stars 1 forks source link

Conflict between LungJ and GDSC update sites #2

Closed tferr closed 7 years ago

tferr commented 7 years ago

@LWollatz, @aherbert,

When looking at redundancies between the BAR update site and other update sites on http://sites.imagej.net/, I noticed the following: The LungJ and GDSC update sites both feature a "Apply Mask" command. Because in IJ1 commands must be unique, users are prompted with a Plugin configuration error at startup. You can reproduce this by subscribing to both update sites.

AFAICT, the options to address this would be:

  1. Rename one of the offending commands (appending an underscore or a space, would suffice)
  2. Since this is simply an IJ1 restriction, one could write an IJ2 command wrapper that calls the class implementing the offending command, using, e.g., this example

Does this make sense?

LWollatz commented 7 years ago

Don't know what GDSC refers to, so I don't know what that"Apply Mask" function does, but I get what you mean. Can think of a different name, i.e. "Apply Mask to Image". Makes it longer, but that should be ok. The actual function names do not need to be unique, just the menu entries, am I right?

LWollatz commented 7 years ago

P.S.: I am not a big fan of just appending an underscore or a space, as I think this is confusing for the end user as the two functions would be seemingly the same. But might still do that.

imagejan commented 7 years ago

GDSC = Genome Damage and Stability Centre, see here and the update site.

Here's the source: https://github.com/aherbert/GDSC/blob/83fa71a/src/main/resources/gdsc/plugins.config#L62 https://github.com/aherbert/GDSC/blob/master/src/main/java/gdsc/threshold/ApplyMask.java

@aherbert might also want to comment on this.

IMHO, this is such a basic functionality, it should live in ImageJ or Fiji to avoid any code redundancies (and inconsistencies).

LWollatz commented 7 years ago

Thanks, found it and went through the code. Looks like the general aim of the two functions is the same. GDSC is giving more options so I could rename mine to "Apply Mask (Simple)". :-)

aherbert commented 7 years ago

This is always going to be a problem with the plugin architecture of ImageJ. The more plugins you add the more chance of a name clash.

In the past I have just renamed commands to avoid the conflict when I was aware of it. If @LWollatz is prepared to rename their plugin then this will solve the issue. Otherwise I can rename mine.

tferr commented 7 years ago

What would be nice would be to e.g., have a shell script that goes through all of the jar files in http://sites.imagej.net/, parses their plugins.config files and checks for duplicated entries. Developers could run it to predict any problems before uploading their jars. This would be a nice way to start addressing some of the limitations of the current system (See also this forum post). Anyone wants to take on the task?