search

LX3JL / xlxd

HAM radio multiprotocol dstar reflector server
GNU General Public License v3.0
163 stars 111 forks source link

Nodes notification and XML linkedto sometimes blank #234

Open jimt opened 1 year ago

jimt commented 1 year ago

Watching the JSON notification stream, occasionally, the final entry in the nodes array (the node that has just connected) JSON object will say "linkedto":" " rather than indicating the module it actually linked to. The next time a JSON "nodes" notification is generated because of another node connecting/disconnecting, the missing linkedto field will be properly filled in.

It only happens once in a while, perhaps suggesting a race condition.

XLXd 2.5.3

jimt commented 1 year ago

I've been logging the JSON for a few days, and it is happening more often than I had noticed. It is not always the last entry of the nodes object.

For what it's worth, I have logged the protocol each node is connecting with, and it has happened with more than one protocol.

jimt commented 1 year ago

More logging and experimenting show the same stations appear with <LinkedModule> </LinkedModule> in the xlxd.xml file.

Looking back through the log file(s) for the affected nodes suggests that these stations have been removed because of keepalive timeouts... but actually not removed from either the XML file or the JSON notification. So far, I have seen it occur for both DMRmmdvm and DPlus clients.