search

LX3JL / xlxd

HAM radio multiprotocol dstar reflector server
GNU General Public License v3.0
170 stars 110 forks source link

set eot status bit for ysf last packet #239

Closed narspt closed 9 months ago

narspt commented 9 months ago

I can't find real documentation about YSF protocol, however I did look at G4KLX code, like MMDVMHost, and I see he always set and rely on this bit to identify EOT: https://github.com/g4klx/MMDVMHost/blob/f02cbcb141e53f1aeac5d0b6ee6dfc9d3b6e2b61/YSFControl.cpp#L915

MMDVMHost RX from XLX without the patch:

M: 2023-12-08 03:08:42.585 YSF, received network data from CT2HRB to DG-ID 0 at CT2HRB
M: 2023-12-08 03:08:45.345 YSF, network watchdog has expired, 1.4 seconds, 0% packet loss, BER: 0.0%
M: 2023-12-08 03:08:47.312 YSF, received network data from CT2HRB to DG-ID 0 at CT2HRB
M: 2023-12-08 03:08:50.628 YSF, network watchdog has expired, 1.9 seconds, 0% packet loss, BER: 0.0%

MMDVMHost RX from XLX after the patch:

M: 2023-12-08 03:30:18.097 YSF, received network data from CT2HRB to DG-ID 0 at CT2HRB
M: 2023-12-08 03:30:19.609 YSF, received network end of transmission from CT2HRB to DG-ID 0, 1.6 seconds, 0% packet loss, BER: 0.0%
M: 2023-12-08 03:30:23.130 YSF, received network data from CT2HRB to DG-ID 0 at CT2HRB
M: 2023-12-08 03:30:25.028 YSF, received network end of transmission from CT2HRB to DG-ID 0, 2.0 seconds, 0% packet loss, BER: 0.0%