State select on filter page - [merged]

[daanboer]

In GitLab by @LXCat on Oct 27, 2022, 15:21

Merges state-select-on-filter-page -> main

TODO

• [x] reload page
• [x] paging
  • [x] on clear selection the page offset should be reset as well
• [x] comment out example
• [x] Add message when no search results
• [x] move bag link to top and shorten text
• [x] document /api/scat-cs by copy/paste search params from search page
• [x] ReactionChoices type similar to ReactionTemplate

[daanboer]

In GitLab by @LXCat on Nov 16, 2022, 17:37

added 1 commit

• 60f1ca6d - CI: Create env file for docker compose build

Compare with previous version

By Stefan Verhoeven on 2022-11-16T16:37:43 (imported from GitLab)

[daanboer]

In GitLab by @LXCat on Nov 16, 2022, 18:03

@DAANBOER CI is green.

By Stefan Verhoeven on 2022-11-16T17:03:19 (imported from GitLab)

[daanboer]

In GitLab by @LXCat on Nov 17, 2022, 14:50

added 1 commit

• 4f28cfff - Use SWR to populate ReactionPicker

Compare with previous version

By Daan Boer on 2022-11-17T13:50:19 (imported from GitLab)

[daanboer]

In GitLab by @LXCat on Nov 17, 2022, 18:31

added 1 commit

• 021e6eb4 - Load server side props into SWR cache

Compare with previous version

By Daan Boer on 2022-11-17T17:31:51 (imported from GitLab)

[daanboer]

In GitLab by @LXCat on Nov 18, 2022, 10:55

added 2 commits

• 44911ddb - Add prefetched data to swr fallback
• d0925101 - Fix crash upon selecting OMIT_CHILDREN_KEY

Compare with previous version

By Daan Boer on 2022-11-18T09:55:23 (imported from GitLab)

[daanboer]

In GitLab by @LXCat on Nov 18, 2022, 13:42

added 1 commit

• 8414ab6a - Rename type_tags -> typeTags in ReactionOptions

Compare with previous version

By Daan Boer on 2022-11-18T12:42:36 (imported from GitLab)

[daanboer]

In GitLab by @LXCat on Nov 18, 2022, 17:26

added 4 commits

• 81b40042 - Optimize reactionsChoices
• a07e247d - Optimize getIdByLabel
• 3d8cc76b - Use defaultReactionOptions instead of defaultSearchOptions
• c7569899 - Optimize /scat-cs page load

Compare with previous version

By Daan Boer on 2022-11-18T16:26:31 (imported from GitLab)

[daanboer]

In GitLab by @LXCat on Nov 18, 2022, 17:29

added 1 commit

• 7c4507fe - Remove unused console logs

Compare with previous version

By Daan Boer on 2022-11-18T16:29:55 (imported from GitLab)

[daanboer]

In GitLab by @LXCat on Nov 18, 2022, 23:37

added 2 commits

• ee87ed6c - Fix rename `type_tags` -> `typeTags`
• 83212ee8 - Fix caching

Compare with previous version

By Daan Boer on 2022-11-18T22:37:24 (imported from GitLab)

[daanboer]

In GitLab by @LXCat on Nov 18, 2022, 18:14

added 1 commit

• b3fbaf98 - Added FIXME

Compare with previous version

By Daan Boer on 2022-11-18T17:14:12 (imported from GitLab)

[daanboer]

In GitLab by @LXCat on Nov 18, 2022, 23:44

Alright, caching is working great now, including prefilling the cache using data obtained in getServerSideProps. I think we are almost ready to merge, just some cleanup of unused code/components remains. The examples require a bit more work, maybe it's nice to treat them in a separate pull request.

By Daan Boer on 2022-11-18T22:44:18 (imported from GitLab)

[daanboer]

In GitLab by @LXCat on Nov 19, 2022, 17:59

added 1 commit

• 76cad833 - Move fetchStateTreeForSelection to SWRStateSelect

Compare with previous version

By Daan Boer on 2022-11-19T16:59:32 (imported from GitLab)

[daanboer]

In GitLab by @LXCat on Nov 16, 2022, 09:11

Commented on app/src/pages/api/reactions/cs-set.ts line 18

Would be nice to document the new api routes in docs/developer.md. Depends on whether we see these routes as public API or internal API.

By Stefan Verhoeven on 2022-11-16T08:11:00 (imported from GitLab)

[daanboer]

In GitLab by @LXCat on Nov 21, 2022, 22:51

added 1 commit

• 323f7ef5 - Cleanup

Compare with previous version

By Daan Boer on 2022-11-21T21:51:54 (imported from GitLab)

[daanboer]

In GitLab by @DAANBOER on Nov 23, 2022, 17:02

added 1 commit

• b0df01c9 - Remove examples for now

Compare with previous version

[daanboer]

In GitLab by @DAANBOER on Nov 23, 2022, 17:02

marked the checklist item comment out example as completed

[daanboer]

In GitLab by @DAANBOER on Nov 24, 2022, 15:50

added 1 commit

• af53010e - Fix page routing

Compare with previous version

[daanboer]

In GitLab by @DAANBOER on Nov 24, 2022, 15:50

marked the checklist item reload page as completed

[daanboer]

In GitLab by @DAANBOER on Nov 24, 2022, 17:35

added 1 commit

• 5d3378b7 - Fix set paging to zero on clear selection

Compare with previous version

[daanboer]

In GitLab by @DAANBOER on Nov 24, 2022, 17:35

marked the checklist item Add message when no search results as completed

[daanboer]

In GitLab by @DAANBOER on Nov 24, 2022, 17:35

marked the checklist item on clear selection the page offset should be reset as well as completed

[daanboer]

In GitLab by @DAANBOER on Nov 26, 2022, 19:53

added 1 commit

• 84c8fb19 - Fix paging on scat-cs page

Compare with previous version

[daanboer]

In GitLab by @DAANBOER on Nov 26, 2022, 20:18

added 1 commit

• f427edc0 - Fixed end-to-end tests

Compare with previous version

[daanboer]

In GitLab by @DAANBOER on Nov 26, 2022, 20:44

added 1 commit

• 2ab4331d - Fix typing

Compare with previous version

[daanboer]

In GitLab by @DAANBOER on Nov 26, 2022, 20:44

marked the checklist item paging as completed

[daanboer]

In GitLab by @DAANBOER on Nov 28, 2022, 18:53

added 2 commits

• 314fe670 - Use SWRReactionPicker in EditForm
• cde866e6 - Cleanup picker types

Compare with previous version

[daanboer]

In GitLab by @DAANBOER on Nov 28, 2022, 18:53

marked the checklist item ReactionChoices type similar to ReactionTemplate as completed

[daanboer]

In GitLab by @DAANBOER on Nov 28, 2022, 23:04

added 1 commit

• 3adcc90a - Move `Plot selection` button to top of list

Compare with previous version

[daanboer]

In GitLab by @DAANBOER on Nov 28, 2022, 23:04

marked the checklist item move bag link to top and shorten text as completed

[daanboer]

In GitLab by @DAANBOER on Nov 29, 2022, 11:13

added 1 commit

• a52538ae - Added icon to plot selection button

Compare with previous version

[daanboer]

In GitLab by @sverhoeven on Nov 30, 2022, 11:41

added 16 commits

• a52538ae...b12cbab6 - 14 commits from branch main
• a6421308 - Merge remote-tracking branch 'origin/main' into state-select-on-filter-page
• e6ea6fc1 - Document /api/scat-cs

Compare with previous version

[daanboer]

In GitLab by @sverhoeven on Nov 30, 2022, 11:41

marked the checklist item document /api/scat-cs by copy/paste search params from search page as completed

[daanboer]

In GitLab by @sverhoeven on Nov 30, 2022, 11:42

marked this merge request as ready

[daanboer]

In GitLab by @sverhoeven on Nov 30, 2022, 11:42

enabled an automatic merge when the pipeline for e6ea6fc1afacc03424f6044466f9dea0eca5cc87 succeeds

[daanboer]

In GitLab by @sverhoeven on Nov 30, 2022, 12:12

mentioned in commit 06c561f1edac7f0d8034d2b54cb64ea5c015d8fd