LXGaming / MixinBootstrap

MixinBootstrap is a temporary way of booting Mixin in a MinecraftForge production environment.
Apache License 2.0
54 stars 4 forks source link

using multiple Minecraft mods that need MixinBootstrap will crash/freeze game #5

Closed MilkissWhite closed 4 years ago

MilkissWhite commented 4 years ago

minecraft 1.15.2 forge 31.1.12 (31.1.0 also tested) MixinBootstrap (1.0.1 / 1.0.2 tested)

mod A "water-erosion-1.15.2-forge-1.0.1" (Water Erosion) mod B "immersive-portals-0.4(for+mc+1.15+with+forge)" (Immersive portals) mod C "enchantmentcontrol-1.0" (Enchantment control) all three mods need MixinBootstrap

A+B make crash at FML early loading progress. A+C or B+C make freezing game when start world-loading. both case Create New World and Load Saved World will not start(not showing square image and percentage)

LXGaming commented 4 years ago

The first issue with water-erosion and immersive-portals crashing super early is due to both of these mods naming their refmap files main.refmap.json, These files overwrite each other and as a result it can cause the Mixin mappings to go missing. The developers of theses mods should be naming their refmap so they are unique, this is as simple as putting the mod id in the file name.

The second issue I'm blaming on enchantmentcontrol as attempting to load a single player world with only it and MixinBootstrap results in it dumping Mixin errors in the debug.log, Looking at the GitHub repository for Tfarcenim/EnchantmentControl I'd guess that the issue is due to the fact the mod is written for 1.15.1 and not 1.15.2.

I was able to patch water-erosion by modifying the json files contained within the jar in order to make the refmap unique and successfully ran both it and immersive-portals with no issues.

MilkissWhite commented 4 years ago

thank you for detail infomation

LXGaming commented 4 years ago

First issue has been fixed in water-erosion v1.0.2.

The second issue is something that needs to be fixed by the enchantmentcontrol developer.