search

LXGaming / MixinBootstrap

MixinBootstrap is a temporary way of booting Mixin in a MinecraftForge production environment.
Apache License 2.0
54 stars 4 forks source link

MixinBootstrap causes block model tessellating problems with Tetra mod #9

Closed ZaRx485 closed 4 years ago

ZaRx485 commented 4 years ago

I was playing a modded Minecraft save when game crashed. The crash report said that it was because of a tessellating block model for Tetra, so I went to the Tetra issue tracker where someone else had the same problem as me. One of the commenters had created a fresh save with only Tetra, and gone through the entire op's mod list until he found the problem, which was MixinBootstrap.

Pastebin link for crash report: https://pastebin.com/3nMjKvNu

Same issue on Tetra issue tracker: https://github.com/mickelus/tetra/issues/130

Minecraft Version: 1.14.4 Forge Version: 28.2.0

LXGaming commented 4 years ago

Blame BetterFoliage, They are passing null in place of ModelData to the BlockRendererDispatcher here, A null value isn't allowed, IntelliJ even tells you that passing null is a stupid idea. RenderCtx

Further more they redirect ChunkRender::renderBlock to a hook here, This hook has a parameter for ModelData but they don't pass it along. They are essentially fucking up the entire rendering pipeline.

ZaRx485 commented 4 years ago

Ah okay thank you. I guess it would have been better if I'd done some testing on my part, but now that I know it wasn't Bootstrap I'll probably try and test this myself and see if BetterFoliage knows anything about why this is happening.

sirati commented 4 years ago

as mickelus/tetra#130 is closed, this should be closed too