search

LXGaming / Sledgehammer

Smashes the stupid out of the client & server.
Apache License 2.0
16 stars 5 forks source link

[1.12.2] Some more patches with Tinkers Evoultion? #41

Open SonicX8000 opened 1 year ago

SonicX8000 commented 1 year ago

Since you added a patch for fixing the crash if loading Tinkers Evolution with Redstone Repository 2.0.0... I wonder if more could be added?

  1. Gelid Gem is a usable material for Tools & Armor however when updating from RedstoneRepository-1.12.2-1.4.0-dev-universal to RedstoneRepository-1.12.2-2.0.0... this is no longer a usable material due to the name for that material being changed. Tinkers Evolution is looking for "gelid_gem" and between these two versions the name for that material was changed... so it can't find it anymore.

image Screenshot of the tool part and what material it uses. This was taken using RedstoneRepository-1.12.2-1.4.0-dev-universal.

  1. https://github.com/phantamanta44/tinkers-evolution/issues/128 Aftershock Tool Trait oddity, the issue itself explains it better but in short what should happen when you have Aftershock III it can hit 6 damage once, but if you have Aftershock of different levels stacked... to reach III... you'll hit 6 damage 3 times in one tick, which totals to 18 damage. Something related to the implementation of stackable traits.

It should be 14 + 6. Not 14 + 6 + 6 + 6. II would be 4, I would be 2.

  1. https://github.com/phantamanta44/tinkers-evolution/issues/122 I think Construct's Armory made of Draconic Materials that gives you the Energy Shield can crash the game? I haven't ran into this myself as I had yet to make a Construct Armor out of those materials.

  2. Not really a bug but if possible... preventing Armor Traits Superdense (ProjectE - Red Matter) & Ultradense (ProjectE - Dark Matter) being used together on the same armor slot as with the default configs you can reach -100% Damage Taken if you have both these traits combined.

Ultradense by default is -20% per Armor Slot, totaling to -80%. Superdense by default is -15% per Armor Slot, totaling to -60%.

There's also Null Almighty Armor Trait but that requires Infinity Armor Parts from Avaritia, those parts are supposed to be overpowered, so... I dunno if you wanna add that with preventing Ultradense & Superdense and vice versa being used with that trait. If I remember it's 25% per armor slot, totaling to -100% Damage Taken.

These are all I can recall for now. I know that Tinkers Evolution would have to apply the fixes on their side but... being that Sledgehammer fixed a crash... I figure it wouldn't hurt to ask.

mczph commented 1 year ago

For 1,maybe you can add it back by contenttweaker if you need it urgently。