LaTeX-Package-Repositories / geometry

Updating Hideo Umeki's geometry package for LaTeX page dimensions
38 stars 5 forks source link

Obsolete ifvtex #18

Open Rimole opened 9 months ago

Rimole commented 9 months ago
\ProvidesPackage{geometry}
  [2020/01/02 v5.9 Page Geometry]
\RequirePackage{keyval}%
\RequirePackage{ifvtex}%
2023/texmf-dist/tex/generic/iftex/ifvtex.sty
Package: ifvtex 2019/10/25 v1.7 ifvtex legacy package. Use iftex instead.

geometry still uses the ifvtex package, which just calls the iftex package anyway, thus geometry should load iftex instead.

Already done was: [Release 5.9] Do not load ifxetex and ifpdf packages (use combined iftex package) Include German translation of the documentation.

BUT

changing \RequirePackage{ifvtex} to \RequirePackage{iftex} gives

! Extra \fi.
\__hook begindocument ...e \paperheight }}\fi \fi 
                                                  \ifx \Gm@driver \Gm@dvips ...

at \begin{document}, because the ifvtex package defines \IFTEX@let{vtexdvi}{false} while the iftex package does not do so. Either the iftex package needs to incorporate the code form the ifvtext package, or geometry needs to change its code accordingly, so that the ifvtext package-code is no longer needed and iftex can be loaded directly.