LaVieEnRose365 / ReLLa

Code of Paper "ReLLa: Retrieval-enhanced Large Language Models for Mitigating Long Context Problems in Recommendation".
41 stars 4 forks source link

Possible Item-ID Mismatch in the Retrieval Process #14

Open tobya11y opened 1 month ago

tobya11y commented 1 month ago

Dear authors,

Thanks for your excellent work!

However, I want to post an item-id mismatch problem, which may lead to retrieve wrong relevant items (Maybe I'm wrong). Here's the problem:

https://github.com/LaVieEnRose365/ReLLa/blob/ac60dd6bbdfed459593216a25570566c2e0ca4af/load_prompt_ml1m.py#L161-L177

The movie id (both in column "Movie ID" and "user_hist") starts from 1 (Evidence: line 162 needs cur_id-1 to get the corresponding row), while the ids in cur_indice starts from 0. When considering whether the current movie id (from cur_indice) in the input_dict["user_hist"] (line 172), the index should plus 1 or the movie ids in user history should all minus 1. I find that the corresponding parts of the other two datasets has changed the way to selecte the most relevant items, which I haven't checked yet. Looking forward to your reply.