Laarryy / AdvancedEnchantments

Better Enchantments & Curses
MIT License
4 stars 7 forks source link

Artisan bug #15

Closed sinsoffallengods closed 4 years ago

sinsoffallengods commented 4 years ago

Artisan 3 on a diamond pickaxe can be used 13-14 times, seeming to randomize between the two.

Artisan 3 on a diamond pickaxe that already has unbreaking 3, also takes 13-14 times. This appears to mean that unbreaking isn't calculated into it when artisan is involved.

egg82 commented 4 years ago

Surprisingly enough, this is somewhat intentional. Helps to keep balance since the enchants can be a little OP. If you believe otherwise, let me know!

sinsoffallengods commented 4 years ago

If possible I would like it to work where unbreaking makes it last longer. If you choose to stay with the current course, maybe make it so they are incompatible with each other? That might make a bit more sense then having both of them on, but unbreaking being essentially non functioning. Thanks for working with me on these bugs. I have another one potentially incoming relating to smelting but I am testing it with users first to make sure it is actually a bug/problem.

On Fri, Oct 4, 2019 at 11:29 PM egg82 notifications@github.com wrote:

Surprisingly enough, this is somewhat intentional. Helps to keep balance since the enchants can be a little OP. If you believe otherwise, let me know!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/egg82/AdvancedEnchantments/issues/15?email_source=notifications&email_token=AJCEPDNYEP3TBUTGEJE6CMDQNAQ4VA5CNFSM4I5VKGZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANKTHI#issuecomment-538618269, or mute the thread https://github.com/notifications/unsubscribe-auth/AJCEPDNSO3EB6JLVRMYZB63QNAQ4VANCNFSM4I5VKGZA .

egg82 commented 4 years ago

Done. Jenkins master should have the new build ready to test. https://jenkins.egg82.me/job/egg82/job/AdvancedEnchantments/job/master/