search

Laarryy / AdvancedEnchantments

Better Enchantments & Curses
MIT License
4 stars 7 forks source link

Banners sometimes do not render to other players until relog #23

Closed NightFuryStrike closed 4 years ago

NightFuryStrike commented 4 years ago

Plugin version: '4.18.24' Server type: 'Paper Build #225' Server version: '1.14.4'

Describe the bug Here's another strange bug me and my players found: Sometimes, when another player places a banner, it has a chance that it will not render to other players until they relog. It renders fine for the player who placed it though.

Expected behavior Banners should always render to all players.

To Reproduce

  1. Install the plugin (with ProtocolLib, I did not test without ProtocolLib)
  2. Start server and join with two accounts (or contact me and I can show you on my server if you like)
  3. Create some random custom banners, and place them on the ground with one account
  4. Observe the other account, the result should be the other account not being able to see all banners that were placed.

Plugins Advanced Enchantments, ProtocolLib

Screenshots/Video https://1drv.ms/v/s!AknzfCjeCluIoe1uPNuLFdxHKThltA?e=m5oHfB

Additional context I assume it's another issue with ProtocolLib.

NightFuryStrike commented 4 years ago

Update: My players have noticed this issue affects skulls as well, can be seen happening in this video: https://1drv.ms/v/s!AknzfCjeCluIoe4EIovTWj_u-KoiQA?e=nMZdOf

egg82 commented 4 years ago

Might have something to do with the new fake block handling, but that might be related more to PLib than to AE. Packets are a nightmare.

egg82 commented 4 years ago

Re-opening in case the issue is still present. Will close once confirmed fixed.

egg82 commented 4 years ago

Assuming this is fixed now. Re-open if not.