search

Lab-Lab-Lab / CPR-Music

0 stars 9 forks source link

eslint issues in variations.js #26

Closed mfwolffe closed 1 month ago

mfwolffe commented 1 month ago

down to 8 total from 59 I believe @hcientist said jerome would take care of recorder.js in which case it would only be 1 eslint error and 1 warning left

@hcientist how would you prefer to proceed with the remaining error in theoretical.js (array indices in element keys), and the warning in instructions.js (flagged from using dangerouslySetInnerHTML)

mfwolffe commented 1 month ago

@hcientist I verified variation algorithms do not break from changes; I think particular attention should be given to potential side effects from changes to perform.js and flat.js

hcientist commented 1 month ago

I htink we had you re-create this against my fork's corresponding branch to make it easier to review? if not, let's re-open.