LabKey / labkey-ui-components

This repository defines all of the npm packages available in the @labkey scope.
Other
2 stars 2 forks source link

Product Menu: Flex layout #1469

Closed labkey-nicka closed 7 months ago

labkey-nicka commented 7 months ago

Rationale

This updates the ProductMenu (often referred to as the "Mega Menu") to utilize flex layout for menu sections. This simplifies the layout logic that is necessary and makes it so we can include static menu sections (e.g. plates) underneath dynamic menu sections (e.g. samples).

Related Pull Requests

Changes

cnathe commented 7 months ago

@labkey-nicka I did some manual testing locally. The column / section scrolling behavior looks much better!

I found one small display issue when viewing the menu in a project without subfolders. The left side doesn't get any padding to match the right side:

Screenshot 2024-04-09 at 4 03 55 PM Screenshot 2024-04-09 at 4 04 19 PM
labkey-nicka commented 7 months ago

@labkey-nicka I did some manual testing locally. The column / section scrolling behavior looks much better!

I found one small display issue when viewing the menu in a project without subfolders. The left side doesn't get any padding to match the right side:

Sure. This was case before my changes. I've adjusted so the first-child column always applies a padding-left.