Issue 51440: Safari no longer needs special date formatting

LabKey / platform

A set of modules that provide core functionality for LabKey Server

Apache License 2.0

7 stars 7 forks source link

Issue 51440: Safari no longer needs special date formatting #5933

Closed labkey-nicka closed 3 weeks ago

labkey-nicka commented 4 weeks ago

Rationale

This addresses Issue 51440 by removing Safari-specific date format handling. See ticket for further details.

Related Pull Requests

https://github.com/LabKey/platform/pull/2457

Changes

Update DateUtil.formatJsonDateTime() to no longer analyze request for browser context
Remove DateUtil.getSafariJsonDateTimeFormatString()

labkey-jeckels commented 4 weeks ago

It would be great to get rid of this special casing for Safari. Any guesses of what version of Safari enabled parsing of our default format though? I'm worried that there may be versions of Safari still within their supported lifespan that still need this workaround.

labkey-nicka commented 4 weeks ago

It would be great to get rid of this special casing for Safari. Any guesses of what version of Safari enabled parsing of our default format though? I'm worried that there may be versions of Safari still within their supported lifespan that still need this workaround.

I believe it was patched almost 3 years ago. https://github.com/WebKit/WebKit/commit/09c28ab505d2306a60c363c817eb97ec196760f2. I do not know what the first version of Safari is that contains this patch but I think we are safe.