LabKey / platform

A set of modules that provide core functionality for LabKey Server
Apache License 2.0
7 stars 7 forks source link

Calculated fields error handling #5938

Closed cnathe closed 3 weeks ago

cnathe commented 3 weeks ago

Rationale

The initial implementation for calculated fields in the field editor UI did some validation of the expression after the user enters it into the domain row textarea but there were still plenty of cases where the user didn't see an error until they saved the domain and tried to view the grid. In this case, sometimes the error would actually prevent the grid from loading and just showed an error message (for example for a calculated field expression that results in a "bad SQL" error). This PR improves on the validation check that is done within the field editor UI before save and also attempts to recognize the case where the grid getQuery call has an error and retries the query while dropping the calculated fields.

Related Pull Requests

Changes