search

LabPy / lantz

Lantz is an automation and instrumentation toolkit with a clean, well-designed and consistent interface. It provides a core of commonly used functionalities for building applications that communicate with scientific instruments allowing rapid application prototyping, development and testing. Lantz benefits from Python’s extensive library flexibility as a glue language to wrap existing drivers and DLLs.
http://lantz.readthedocs.org/
Other
135 stars 65 forks source link

Fix error importing PySide 1.2.2 #47

Open iromero91 opened 9 years ago

iromero91 commented 9 years ago

PySide 1.2.2 (at least) doesn't have a __version__ attribute in PySide.QtSvg. Slightly changing the order of imports solves the issue (though if you ask me this code is fairly smelly, there has to be a better solution.)

hgrecco commented 9 years ago

Thanks. Yes, this was taken from the IPython project to get PySide and PyQt compatibility. I will take alook. By the why, is PySide alive or it has been abandoned?

enkore commented 9 years ago

By the why, is PySide alive or it has been abandoned?

Still no Qt 5 version in sight afaik...

iromero91 commented 9 years ago

I don't really care much about PyQt because it's not LGPL/BSD compatible.

enkore commented 9 years ago

I don't really care much about PyQt because it's not LGPL/BSD compatible.

Not true.

http://www.riverbankcomputing.com/pipermail/pyqt/2014-February/033848.html

Phil Thompson phil at riverbankcomputing.com:

No, but thats not an ideological change. What (GPL incompatible) license do you want use?

I contribute to several projects that use different licenses. Im primarily concerned with the BSD and LGPL, but also Python and MIT.

As far as I am aware all of those are compatible with the GPL and so do not need an exception.

(emphasis mine)

hgrecco commented 9 years ago

I do my best to support both PySide and PyQt. So I will be happy to merge any changes that makes this possible.

iromero91 commented 9 years ago

Thanks! this fix does work for me, but it might need more work down the line to do something saner.

hgrecco commented 9 years ago

But I wonder if the #48 is also due to a difference with PySide