search

LabPy / lantz

Lantz is an automation and instrumentation toolkit with a clean, well-designed and consistent interface. It provides a core of commonly used functionalities for building applications that communicate with scientific instruments allowing rapid application prototyping, development and testing. Lantz benefits from Python’s extensive library flexibility as a glue language to wrap existing drivers and DLLs.
http://lantz.readthedocs.org/
Other
135 stars 65 forks source link

fan_speed typo in andor neo #85

Closed ksunden closed 3 years ago

ksunden commented 3 years ago

I think this is a typo, however I am not actually sure, especially given the line in __init__ which sets an attribute self.fan_speed = 1 that doesn't seem to do anything.

Please note that I did no testing on this and have little to no experience using Lantz (some curiosity, but not really more than that)

If this is not a typo, feel free to close.

aquilesC commented 3 years ago

The correction you pointed out is indeed correct! This is one of the caveats of working with Feats (self.fan_speed = 1 does not raise an issue, even if fan_speed is not defined anywhere. )

However, to contribute to Lantz, I would strongly suggest you to checkout the new repository:

https://github.com/lantzproject/

The version of Lantz to which you sent this pull request has been stalled for 6 years already.

ksunden commented 3 years ago

closing as I opened on the more maintained library