search

LabVIEW-DCAF / TagEditorCore

The collection of sample projects, libraries, class implementations, and APIs which make up the core of DCAF.
http://www.ni.com/dcaf
Apache License 2.0
8 stars 6 forks source link

Fixes table initialization and removal to set selected index to -1 #356

Closed theSloopJohnB closed 7 years ago

theSloopJohnB commented 7 years ago

fixes #355 fixes https://github.com/LabVIEW-DCAF/DCAF-Project-Templates/issues/103

This issue has made it into many of our modules through the dynamic template. This will fix that problem at the root cause.

Using fixes Matt pointed out in this PR: https://github.com/LabVIEW-DCAF/Scan-Engine-Module/pull/47

DCAF-Builder commented 7 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Table Manager.lvlib--Multi Column Listbox.lvclass--Value Change.vi.png: capture

theSloopJohnB commented 7 years ago

Note for reviewers - the diff robot only shows one VI. For some reason LabVIEW is crashing while creating the other one. The VI above fixes the remove down to 0 case. The other VI is the init case which sets the index to -1 on initialization, so nothing is selected at first.

theSloopJohnB commented 7 years ago

There was some kind of issue with the VIP file. I rebased onto master and triggered a rebuild that will hopefully fix the issue.

DCAF-Builder commented 7 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Table Manager.lvlib--Multi Column Listbox.lvclass--Value Change.vi.png: capture

DCAF-Builder commented 7 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

Table Manager.lvlib--Multi Column Listbox.lvclass--Value Change.vi.png: capture

gcodetechnology commented 5 years ago

See issue #402 that was caused by this fix.