LabVIEW-DCAF / TagEditorCore

The collection of sample projects, libraries, class implementations, and APIs which make up the core of DCAF.
http://www.ni.com/dcaf
Apache License 2.0
8 stars 6 forks source link

Graphviz review, refactor, and tests. Fixing cannot load twice bug. #359

Closed dbendele closed 7 years ago

dbendele commented 7 years ago

fixes #334, fixes #307

DCAF-Builder commented 7 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

GraphViz Mapping Visualizer.lvlib--Channels to Display Strings and Indices.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Create Channel and Node Pair.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Create Digraph String.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Create One Column Table HTML From Channel List.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Create Two Column Table HTML From Channel List.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Format Node ID.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Format Port ID.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Generate GraphViz Mapping File.vi.png: capture

GraphViz Mapping Visualizer.lvlib--GraphViz Generator UI Wrapper.vi.png: capture

Verify HTML Tables and Digraph.vi.png: capture

theSloopJohnB commented 7 years ago

Verify HTML Tables and Digraph.vi has a diagram disable structure in the bottom left for what looks like manually testing. Can you please remove it or move it to a separate VI?

image

Nice work with the test file! Definitely want to make sure that works. How easy is it to add a test that loads a configuration file and spits out the digraph text to verify it?

dbendele commented 7 years ago

added another test to verify the following use cases

  1. Node has both inputs and outputs
  2. Tag has multiple readers

simulation

do not yet have a test that reads the configuration file to harvest channel mappings and tags

DCAF-Builder commented 7 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

GraphViz Mapping Visualizer.lvlib--Channels to Display Strings and Indices.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Create Channel and Node Pair.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Create Digraph String.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Create One Column Table HTML From Channel List.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Create Two Column Table HTML From Channel List.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Discover Node Connections Using Tag Info.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Format Node ID.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Format Port ID.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Generate GraphViz Mapping File.vi.png: capture

GraphViz Mapping Visualizer.lvlib--GraphViz Generator UI Wrapper.vi.png: capture

Table Manager.lvlib--Multi Column Listbox.lvclass--Value Change.vi.png: capture

Verify Digraph for Simulation Mappings.vi.png: capture

Verify HTML Tables and Digraph.vi.png: capture

DCAF-Builder commented 7 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

GraphViz Mapping Visualizer.lvlib--Channels to Display Strings and Indices.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Create Channel and Node Pair.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Create Digraph String.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Create One Column Table HTML From Channel List.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Create Two Column Table HTML From Channel List.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Discover Node Connections Using Tag Info.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Format Node ID.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Format Port ID.vi.png: capture

GraphViz Mapping Visualizer.lvlib--Generate GraphViz Mapping File.vi.png: capture

GraphViz Mapping Visualizer.lvlib--GraphViz Generator UI Wrapper.vi.png: capture

Verify Digraph for Simulation Mappings.vi.png: capture

Verify HTML Tables and Digraph.vi.png: capture