Closed andbe91 closed 6 years ago
Would be great if you could merge Pressure & temperatures - we read out the temperatures directly from a lakeshore, but it’d be good to have the option to do it either way.
I’d suggest extending the previous version to keep it compatible, or creating a new one with a neutral name.
On Dec 8, 2017, at 04:08, Andreas Bengtsson notifications@github.com wrote:
Reading the temperatures from the log file. Very similar to the BlueForsPressure driver. Please let me know if you think that I should merge BlueForsPressure and BlueForsTemperature into one driver instead.
You can view, comment on, or merge this pull request online at:
https://github.com/Labber-software/Drivers/pull/64
Commit Summary
Implement driver for reading the temperatures from a BlueFors cryostat File Changes
A BlueForsTemperature/BlueForsTemperature.ini (70) A BlueForsTemperature/BlueForsTemperature.py (48) Patch Links:
https://github.com/Labber-software/Drivers/pull/64.patch https://github.com/Labber-software/Drivers/pull/64.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
They are now merged in a new one called Bluefors Logging. I just realized that you maybe meant to also keep the Bluefors Pressure as is? At the moment I renamed that one into Bluefors Logging...
Reading the temperatures from the log file. Very similar to the BlueForsPressure driver. Please let me know if you think that I should merge BlueForsPressure and BlueForsTemperature into one driver instead.