search

Labdoo / Labdoo-3.0

Labdoo 3.0
GNU General Public License v3.0
0 stars 4 forks source link

Update README.md #16

Closed ijf8090 closed 2 years ago

ijf8090 commented 2 years ago

Changed script file name from dev-start.sh to dev-setup.sh. Updated dev-setup.sh to install drush, which is not provided with the base install.

greggmarshall commented 2 years ago

Why update the setup bash script and not just update the composer.json/composer.lock pair? That way it is clear it is a dependency when looking at the code.

ijf8090 commented 2 years ago

composer.json contains the following require statement "drush/drush": "^11.0",

If 'composer install' command is run after 'ddev start', drush will be installed and the dev-setup.sh script completes as expected...

greggmarshall commented 2 years ago

I just ran the gitpod as it is now and it ran successfully and had drush installed. I am confused why you would want/need to have drush installed again.

ijf8090 commented 2 years ago

I'm trying to follow the instructions to do a local install.

ijf8090 commented 2 years ago

per conversation w. Gregg, close this PR. He will open a new one to sync up local and gitpod processes

jrosgiralt commented 2 years ago

Thanks, per your request, I have closed this PR.