search

LabeliaLabs / distributed-learning-contributivity

Simulate collaborative ML scenarios, experiment multi-partner learning approaches and measure respective contributions of different datasets to model performance.
https://www.labelia.org
Apache License 2.0
56 stars 12 forks source link

Makefile #333

Closed natct10 closed 3 years ago

natct10 commented 3 years ago

You can use make black, make flake, make tests, make tests-ml-perf and make test-contrib. Please install make to test. Windows users might use chocolatey package manager: https://chocolatey.org/packages/make.

Started here: https://github.com/SubstraFoundation/distributed-learning-contributivity/pull/319 Fix #312

natct10 commented 3 years ago

Cool thing in principle. But I would have a couple remarks:

1. Could we remove the black formatter? I really don't like the syntax it gives, it makes code files difficult to read

Black is a great tool. And you don't have to accept all, git add -p is useful in this regard.

2. As discussed this morning, I am not too sure about end-to-end tests on this one, it might take a while, and become useless because of that. I think flake + unit tests would be a good combo, both handy and useful

This part is refined in this PR: https://github.com/SubstraFoundation/distributed-learning-contributivity/pull/336/files. The idea was -even if the command takes a long time to be executed- to have an alias to run it.

Let me know

natct10 commented 3 years ago

Closing as it is included in 336