search

LabeoTech / Umit

universal mesoscale Imaging Toolbox
GNU General Public License v3.0
9 stars 3 forks source link

[BUG] events.mat file while merging acquisition #69

Closed G-Laliberte closed 1 year ago

G-Laliberte commented 1 year ago

Describe the bug While merging the acquisition, a new events file is create. All the variables in the new events.mat file are created (enventID, eventNameList, state and timestamps) but they are empty. There is no error message.

To Reproduce Steps to reproduce the behavior:

  1. Go to Utilities
  2. Click on Merge recordings
  3. Choose two acquisition with events.mat file to merge

Expected behavior I think it is suppose to merge both events.mat file from the the two acquisitions in one new events.mat file. There is no issue with the merged acquisition files (.dat/.mat)

Additional context I can send you two acquisitions to look at i, if needed.

thank you!

BrunoOFSouza commented 1 year ago

Hi @G-Laliberte !

Please, send me the acquisitions. It will help me fix the issue.

BrunoOFSouza commented 1 year ago

@G-Laliberte ,

The MergeRecs tool was updated to merge events.mat files (commit f38fa96eb31a7938401ffa67084f023929671941 ). Now, it behaves as follows:

  1. In the Events panel, if you overwrite the event IDs, a new events.mat file will be created and the ones in the original recordings will be ignored.
  2. If you leave the Overwrite event IDs unchecked, the events.mat files will be merged into a single one. Note that all folders must contain an events.mat file to make it work.

If you find bugs or still perceive this issue as unresolved, feel free to reopen it.

Cheers,