LabinatorSolutions / stockfish-chess-web-gui

Responsive chess web GUI to play against the Stockfish 16 chess engine. Multiple web GUI implementations have also been included.
https://labinatorsolutions.github.io/stockfish-chess-web-gui/
GNU Affero General Public License v3.0
57 stars 37 forks source link

The "Show Hint" button is not working for the Black pieces on touch devices #4

Closed LabinatorSolutions closed 4 years ago

LabinatorSolutions commented 4 years ago

The "Show Hint" button is not working on touch devices (tablets and smartphones).

ipetak commented 4 years ago

Made a pull request with fix! :)

LabinatorSolutions commented 4 years ago

Hi Ivan!

Thank you for your work and contribution.

I have already accepted your pull request. However, the "Show Hint" button is now suggesting an invalid move for the Black pieces when playing on touch devices (Smartphones & Tablets).

I will keep this issue open until we find a resolution.

Thank you once again for your time and all your work. Your name has already been added to our contributors' list.

All the best!

ipetak commented 4 years ago

Feel free to assign this issue to me, I'll try to fix it so it works for both.

LabinatorSolutions commented 4 years ago

Thank you Ivan for your interest to improve this free open-source GUI.

The issue has been assigned to you but you are free to work on it whenever you have free time and are in the mood for this.

ipetak commented 4 years ago

You're welcome, It's a fun project to help with. So I've made a new PR with the fix, the button "show hint" should work for both sides regardless if the board if flipped or not.

LabinatorSolutions commented 4 years ago

Great work! It is working very well now. Thank you for all your work, time, and contribution to this FOSS project.