search

LaboratoireMecaniqueLille / crappy

Command and Real-time Acquisition Parallelized in Python
https://crappy.readthedocs.io/en/stable/
GNU General Public License v2.0
81 stars 16 forks source link

Some examples in tutorial are not working #41

Closed ForestRupicolous closed 1 year ago

ForestRupicolous commented 1 year ago

Hi, thank you for providing this package. It looks very promising. I'm currently trying the tutorial using Python 3.11 and crappy 1.5.10 but with the code example in 3a-loops I get following error: TypeError: Ramp.__init__() got an unexpected keyword argument 'cmd' When I fix it by removing the 'cmd': 0 part, I get another error: TypeError: cannot unpack non-iterable float object. For me it looks like the examples at this point where not updated to fit the current version 1.5.10. If needed I can provide additonal information or test any updates.

Thanks

WeisLeDocto commented 1 year ago

Hi !

You are absolutely right, the example code you mention contained two distinct errors. They should be fixed on the web documentation as soon as ReadTheDocs is done rebuilding it. Sorry for the inconvenience, and thank you for signaling it !

FYI I'm currently working on a version 2.0.0 of Crappy, that should be released in a month or two. I mainly worked on improving the stability compared to the 1.5.x versions, with also a much better handling of the cameras. All that's missing is an in-depth refactoring of the documentation, but the code and examples are mostly ready. If you want to check it, it's in the develop branch of the repo. It can also be installed with pip as the version 2.0.0.dev2 (dev3 available this week).

Weis

ForestRupicolous commented 1 year ago

Hi! Wow that was fast. I'm impressed. Thank you for the fast response and the information about the develop branch. I will have a more detailed look in the next days.

Martin