search

Labs64 / GuideChimp

Create interactive guided product tours in minutes with the most non-technical friendly, lightweight and extendable library.
https://www.labs64.com/guidechimp/
European Union Public License 1.2
204 stars 20 forks source link

Allow individual tours location for the chrome extension #58

Open eeddaann opened 3 years ago

eeddaann commented 3 years ago

First of all the idea of making the chrome extension is brilliant! However it would be better if you could host the tours on your own and don't be dependent on third party... I have tried to unpack the extension and "hack" it to look for "tours" definitions in a different URL then the hardcoded one... it worked but it would be better if you could add the source code for the extension :)

r-brown commented 3 years ago

Hello @eeddaann thank you for your interest to GuideChimp Chrome Extension!

As of now we do no plan do disclose extension source code. However, we plan to extend functionality here; e.g. individual enabling of GuideChimp plugins as well as individual tours location.

r-brown commented 3 years ago

As of now we plan to keep the tours in one central tours repository, so these are available for the GuideChimp community.

eeddaann commented 3 years ago

Thanks for the fast response! a possible implementation may based on this example

I really liked your idea of putting the configs in github since it's makes the tours versioned out-of-the-box. however I've noticed that the extension looks for the tours at: https://www.labs64.com/guidechimp/tours and not on github.

In addition we should think about the Content Security Policy (CSP) at the manifest of the extension, the current manifest references to your site: "content_security_policy": "default-src 'self'; connect-src https://www.labs64.com" however if the user will be able to set another tour location, it should be aligned with the policy.

hope this comment was helpful :)

r-brown commented 3 years ago

...I've noticed that the extension looks for the tours at: https://www.labs64.com/guidechimp/tours and not on github.

Path https://www.labs64.com/guidechimp/tours is the forward for https://github.com/Labs64/GuideChimp-tours/tree/master/guidechimp/tours So, every public tour at GitHub will be resolved as well; e.g. https://github.com/Labs64/GuideChimp-tours/tree/master/guidechimp/tours/netlicensing.io.json https://www.labs64.com/guidechimp/tours/netlicensing.io.json