search

Labsmore / pyuscope

Python machine vision platform
BSD 2-Clause "Simplified" License
77 stars 17 forks source link

Review flat field calibration #242

Open JohnDMcMaster opened 1 year ago

JohnDMcMaster commented 1 year ago

A few issues...

Mainly it seems that images still have lighting artifacts that should have been corrected by this. Understand if we are either incorrectly applying the correction or there is another factor we aren't taking into consideration. At first this was believed to be due to non-linear camera properties, but I believe we are still seeing it in the linear region

Also, the application is fairly slow. Take a look at other tool kits like image magic which I think can apply flat field directly. We might be able to kill two birds with one stone if those can apply the corrections quicker

JohnDMcMaster commented 11 months ago

Flat field calibration is much faster now. However, experiments with CloudStitch show that it for the most part doesn't matter as CloudStitch is able to correct most even very extreme exposure issues. So keep an eye on this for now, unclear what to suggest to users for stitching

However, snapshots would benefit from this still. Unfortunately snapshots don't currently use the image processing pipeline (although this should be easy to fix)